Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing sphinx entry & flake8 #1671

Closed
wants to merge 1 commit into from
Closed

Fix missing sphinx entry & flake8 #1671

wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

@saitcakmak saitcakmak commented Jun 21, 2023 •
edited
Loading

Fixes failures in lint & docs workflows.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 21, 2023
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@saitcakmak saitcakmak changed the title Fix missing sphinx entry Fix missing sphinx entry & flake8 Jun 21, 2023
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (02ff379) 94.80% compared to head (b38b1b9) 94.80%.

❗ Current head b38b1b9 differs from pull request most recent head 164ae6d. Consider uploading reports for the commit 164ae6d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1671   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         448      448           
  Lines       41233    41233           
=======================================
  Hits        39093    39093           
  Misses       2140     2140
Impacted Files Coverage Δ
ax/service/utils/report_utils.py 82.38% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saitcakmak @facebook-github-bot
Fix missing sphinx entry & flake8 (#1671)
164ae6d 
Summary:
Fixes failures in lint & docs workflows.

Pull Request resolved: #1671

Reviewed By: Balandat

Differential Revision: D46883168

Pulled By: saitcakmak

fbshipit-source-id: e56303266b9b72a2b12140624acc3188bf175a61
saitcakmak added a commit that referenced this pull request Jun 21, 2023
@saitcakmak @facebook-github-bot
Fix missing sphinx entry & flake8 (#1671)
3a34e14 
Summary:
Fixes failures in lint & docs workflows.

Pull Request resolved: #1671

Differential Revision: https://internalfb.com/D46883168

Pulled By: saitcakmak

fbshipit-source-id: a4281bdd4b63d90b3ae26283b147cfbfbac627a8
@saitcakmak saitcakmak force-pushed the saitcakmak-patch-1 branch from a43e23f to 164ae6d Compare June 21, 2023 02:45
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46883168

saitcakmak added a commit that referenced this pull request Jun 21, 2023
@saitcakmak @facebook-github-bot
Fix missing sphinx entry & flake8 (#1671)
0c13a68 
Summary:
Fixes failures in lint & docs workflows.

Pull Request resolved: #1671

Differential Revision: https://internalfb.com/D46883168

Pulled By: saitcakmak

fbshipit-source-id: 06178615bdf69de685701ad23827a0b9b6310cc6
@SebastianAment SebastianAment mentioned this pull request Jun 21, 2023
Closed
@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in 567b889.

@saitcakmak saitcakmak deleted the saitcakmak-patch-1 branch September 7, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saitcakmak @facebook-github-bot @codecov-commenter